From ccd778ecbbdaaf35327ba86bbd4d4bb0f48f2240 Mon Sep 17 00:00:00 2001 From: Daniel Nitsikopoulos Date: Tue, 31 Jan 2023 19:43:12 +1100 Subject: [PATCH] Remove need for monads --- app/actions/media/create.rb | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/app/actions/media/create.rb b/app/actions/media/create.rb index ab9d725..cf0bbb9 100644 --- a/app/actions/media/create.rb +++ b/app/actions/media/create.rb @@ -10,18 +10,16 @@ module Adamantium halt 401 unless verify_scope(req: req, scope: :media) - upload.call(file: data) do |m| - m.failure do |v| - res.status = 422 - end + upload_result = upload.call(file: data) - m.success do |v| - res.status = 201 - res.headers["Location"] = v - res.body = { - url: v - }.to_json - end + res.status = 422 if upload_result.failure? + + if upload_result.success? + res.status = 201 + res.headers["Location"] = upload_result.value! + res.body = { + url: upload_result.value! + }.to_json end end end